[TASK] Return early on forms without conditions #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently investigating workload increase / performance declines when using form conditions.
One small improvement would be to avoid processing all the form fields when there are no conditions set for that form. Let me know if you also see it as an improvement.
Sidenote: I think ultimately it would make sense not to perform XHR call to the ConditionService for forms that have no conditions set. That information might be included in the
<form>object itself (e.g. over a class or adata-attribute).If we'd rather not change the view, the JS might at least be updated to stop sending further queries to the ConditionService for forms on which we already got an empty array as a response (=> no conditions for the form). That would reduce the load to the Service to one call for each form, instead of one call for each modified input.