Try to fix wounded particle missing issue in Sibyll#226
Open
kevinwudev wants to merge 2 commits intoimpy-project:mainfrom
Open
Try to fix wounded particle missing issue in Sibyll#226kevinwudev wants to merge 2 commits intoimpy-project:mainfrom
kevinwudev wants to merge 2 commits intoimpy-project:mainfrom
Conversation
Author
|
Dear @afedynitch , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and The way to fix it [Fix #225]
We found there are no non-zero array of wounded candidates and the impact parameters in the proton-proton and proton-nucleus collision
To fix this, we try accessing the
s_cncm0common block by addingint_h_nucto thesibyll_syms_baselist inmeson.build, and check whether wounded candidates appear on thes_cncm0side.Changes
int_h_nuctosibyll_syms_baselist in the meson.build in order to adds_cncm0as the attribute ofevent._lib.src/chromo/models/sibyll.py: if there are no wounded candidates incnucmsside, try getting those froms_cncm0side, same for impact parameter.tests/test_sibyll.py: Check out that wounded candidates appeared correctly or not.Table of wounded particle presence
s_cncm0orcnucmsside, but found wounded candidates ins_cncm0side.s_cncm0.cnucms.cnucms.Simple script of checking the parameter: