Skip to content

Fix issue #1509 by improving handling of unused expression side effects #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahomescu wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix issue #1509 by improving handling of unused expression side effects #1544

ahomescu wants to merge 9 commits into from

Conversation

@ahomescu
Copy link
Contributor

@ahomescu ahomescu commented Jan 10, 2026 •
edited by kkysen
Loading

kkysen
kkysen reviewed Jan 10, 2026
View reviewed changes
@ahomescu ahomescu force-pushed the ahomescu/fix_1509 branch 3 times, most recently from c1c2894 to e1c0177 Compare January 13, 2026 02:36
@ahomescu
Copy link
Contributor Author

ahomescu commented Jan 13, 2026

@kkysen What are the steps for updating the macos snapshots for people running Linux?

kkysen
kkysen reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkysen What are the steps for updating the macos snapshots for people running Linux?

You have to do it manually, unfortunately, or use a Mac. You can also see what CI error you get and copy that. The cross platform support should fix this but that's not done yet.

@ahomescu
Copy link
Contributor Author

ahomescu commented Jan 15, 2026

This passes the tests and has snapshots now, any more feedback?

@kkysen kkysen self-requested a review January 15, 2026 03:58
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
kkysen
kkysen requested changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also re-order the snapshot commits so that the tests are always succeeding and they're added before the fixes, so that it's easy to see what changed in the snapshot after the fix?

kkysen
kkysen reviewed Jan 15, 2026
View reviewed changes
@kkysen kkysen mentioned this pull request Jan 15, 2026
Open
@ahomescu ahomescu force-pushed the ahomescu/fix_1509 branch 2 times, most recently from e9b45da to 89b5b73 Compare January 16, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkysen kkysen kkysen requested changes

@thedataking thedataking Awaiting requested review from thedataking

@fw-immunant fw-immunant Awaiting requested review from fw-immunant

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

About the mistranslation About the transaction output bug

3 participants

@ahomescu @kkysen