This repository was archived by the owner on Sep 27, 2022. It is now read-only.
SimpleFlickr updates #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add photoset.owner, photoset_id, and photo.link to $getPhotosFromJSON() method. Change returntype to "xml" in $getPhotosFromXML.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a few updates to the plugin, mostly to better fit my needs but it may be of some benefit to others. I hope my notes in the commits make sense. There wasn't much I needed to change. I needed a bit more information because the interface I'm building is grabbing some images from sets the museum has created and displaying them on an exhibition page. The images will be links to the image in Flickr itself and there is a link to view the entire set. I mostly added some data to the $getPhotosFromJSON() method so that I could use it in my display. The only other change was a missing semicolon in the #getPhotosFromJSON() method which was causing errors. If you find my changes helpful, you can integrate them into the plugin code. If not, that's fine too. I'm very grateful to have had your code as a starting point. I even learned a bit about writing plugins in the process. Thanks again. Also provide any feedback you might have to offer in the changes I made. Take care.
Ken