Add .kana_to_roma method to prevent .romaji from modifying pre-existing alpha chars in a string#6
Open
johnnyshields wants to merge 1 commit intoikayzo:masterfrom
Open
Add .kana_to_roma method to prevent .romaji from modifying pre-existing alpha chars in a string#6johnnyshields wants to merge 1 commit intoikayzo:masterfrom
.kana_to_roma method to prevent .romaji from modifying pre-existing alpha chars in a string#6johnnyshields wants to merge 1 commit intoikayzo:masterfrom
Conversation
…od where it modifies pre-existing alpha chars in the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an edge-case where the
.romajimethod can affect some pre-existing alpha chars in the string, for example two consectivens become a singlen. (There are a few other cases as well).To workaround this, I added a new method
.kana_to_romawhich breaks up the string into kana and non-kana chunks, and calls.romajionly on the kana chunks.I think it might actually be better to make this the behavior of the
.romajimethod itself, as in nearly every case I'd think users wouldn't want to affect existing alpha chars.I think we need to do something here because current behavior is unexpected--I was actually calling it on email addresses to sanitize them, and it was breaking the emails!