Notify only if window is not in focus #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a long running command is run from a tmux window, on completion, it verifies that the tmux window differs before triggering a notification. Information about the tmux session related to the completed command is added to the notification to make it easier to figure out in which tmux window the command was being executed.
LONG_RUNNING_COMMAND_TIMEOUT can be set in the environment of the shell. The same is true for gnuunits which is now called NOTIFYOSD_GNUUNITS. Change-Id: I546d29ba192424e404e513e9ce069f5cac0bece2
Add support for tmux windows and flexible command timeout
integration of a function to do the convertion to human readable time
To improve readability.
The names are still displayed because I think they are still more useful than the raw IDs.
fix!: LONG_RUNNING_IGNORE_LIST was ignored; now an array and other smaller fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2 . The notification is displayed only when the window in focus is not the one where the long command was running.
I also cleaned up slightly the code, both tabs and spaces were used, so I put spaces everywhere. And using
`is deprecated so I used$(..)instead.