Buffer encoding issues #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking and prepending the frame header certain DATA payload inputs were keeping the original encoding right before prepending the binary header, which could generate an incompatible encoding error Fixes HoneyryderChuck/httpx#83
lib users will store the ping data input to compare when receiving the peer PING frame, so it may be surprising if the data does not match because the mutable arg was changed
calls to #event already transition @State to the next state, so this is redundant
remove all calls to "#process_priority" inside "#transition", as it should only handle state machine transitions. besides, #receive already does that type of frame processing calls before calling "#transition" . this also corrects stream state management when it comes to taking priority frames into account when sending, as per the documentation on each state block, which explicitly states the cases which were not being handled.
mullermp
approved these changes
Apr 15, 2025
Collaborator
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
Seems fine - I can do a sanity test with the SDK later this week.
Collaborator
Author
|
thx. I'll be issuing a release today though, as this was disruptive to some folks who upgraded the lib, and I'd expect more to come as time passes by. I already ran a few sanity checks on my side as well, and the original issue reporters have already deployed the patch and confirmed it fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fixes for some string encoding issues reported here and here.
Releases a new patch version (1.1.1)