This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Refactor IggyClient to be fully async and remove blocking calls#36
Merged
darioalessandro merged 2 commits intoiggy-rs:mainfrom Feb 27, 2025
Merged
Refactor IggyClient to be fully async and remove blocking calls#36darioalessandro merged 2 commits intoiggy-rs:mainfrom
darioalessandro merged 2 commits intoiggy-rs:mainfrom
Conversation
darioalessandro
suggested changes
Feb 27, 2025
Collaborator
darioalessandro
left a comment
There was a problem hiding this comment.
PR looks awesome!!
Please just address my question about openssl and we can go ahead and ship it, thank you for your hard work!!
20fdb44 to
c714b64
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR refactors IggyClient to use fully asynchronous operations, replacing all block_on() calls with future_into_py() for better integration with Python’s asyncio