This repository was archived by the owner on Jun 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
✨ Add timestamp, id and checksum info for a received message #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmodzelewski
reviewed
Nov 6, 2024
Member
The end goal would be to have full capabilities of the underlying SDK, so I'd say we should include these eventually. |
Contributor
Author
|
@mmodzelewski I've fixed the |
mmodzelewski
reviewed
Nov 9, 2024
Member
|
I think |
Contributor
Author
|
@mmodzelewski did you get a chance to look at the PR? |
Contributor
Author
|
@mmodzelewski have looked at this PR? |
Member
|
Hey @lsabi, I added a commit with an enum implementation I mentioned in an earlier comment. |
mmodzelewski
approved these changes
Jan 29, 2025
spetz
approved these changes
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata for received message.
I'm not sure if it makes sense to also add:
MessageStateHeadersLengthI think that for now,
timestampandidare the most important, especially if we consider the implementation of thePollingstrategywith the timestamp (which I'm trying to use). Sincechecksumis also a primitive data type, I've also added it (why not?)