Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Conversation

@lsabi
Copy link
Contributor

@lsabi lsabi commented Nov 5, 2024

Add metadata for received message.

I'm not sure if it makes sense to also add:

  • MessageState
  • Headers
  • Length

I think that for now, timestamp and id are the most important, especially if we consider the implementation of the Pollingstrategy with the timestamp (which I'm trying to use). Since checksum is also a primitive data type, I've also added it (why not?)

@mmodzelewski
Copy link
Member

I'm not sure if it makes sense to also add:

  • MessageState
  • Headers
  • Length

The end goal would be to have full capabilities of the underlying SDK, so I'd say we should include these eventually.

@lsabi
Copy link
Contributor Author

lsabi commented Nov 7, 2024

@mmodzelewski I've fixed the checksum's return and added also the remaining information, but the headers which I don't know what is a good way of representing them. Maybe a dict? If you have any suggestions, let me know or feel free to edit and then merge the branch.

@mmodzelewski
Copy link
Member

I think dict would be good for headers, but it will require more work as it can hold different types of data. We can leave it for another PR.

@lsabi
Copy link
Contributor Author

lsabi commented Nov 24, 2024

@mmodzelewski did you get a chance to look at the PR?

@lsabi
Copy link
Contributor Author

lsabi commented Jan 27, 2025

@mmodzelewski have looked at this PR?

@mmodzelewski
Copy link
Member

Hey @lsabi, I added a commit with an enum implementation I mentioned in an earlier comment.

@mmodzelewski mmodzelewski merged commit 46a5de3 into iggy-rs:main Jan 29, 2025
6 checks passed
@lsabi lsabi deleted the patch-1 branch January 29, 2025 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants