Fix Scilab 2025.1.0 compatibility: Update deprecated scicos_block4.h header#2
Draft
Fix Scilab 2025.1.0 compatibility: Update deprecated scicos_block4.h header#2
Conversation
Author
|
@ierturk 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…4.h to scicos_block.h Co-authored-by: ierturk <1481831+ierturk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] The SciPowerLab can't work in the 2025.1.0
Fix Scilab 2025.1.0 compatibility: Update deprecated scicos_block4.h header
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the compatibility issue with Scilab 2025.1.0 where the SciPowerLab toolbox would crash when running demos. The root cause was the use of the deprecated
scicos_block4.hheader file, which was replaced withscicos_block.hin newer Scilab versions.Changes Made
Updated C computational functions:
#include "scicos_block4.h"with#include "scicos_block.h"in all 7 computational function files:xcpl_BLDC_comp.c- Brushless DC Machinexcpl_BLSC_comp.c- Brushless DC Machine Controllerxcpl_PMSM_comp.c- Permanent Magnet Synchronous Machinexcpl_PMSC_comp.c- PMSM FOC Controllerxcpl_IMPU_comp.c- Induction Machine Per-Unit Modelxcpl_SVPWM_comp.c- Space Vector PWM Generatorxcpl_PSDINV_comp.c- Pseudo InverterVersion and documentation updates:
DESCRIPTIONandREADME.mdTesting
The toolbox should now work correctly with Scilab 2025.1.0. Users can verify the fix by:
exec builder.sceto build the toolboxexec loader.sceto load the toolboxexec demos/demPMSM.dem.sceThe fix maintains backward compatibility with earlier Scilab versions while resolving the crash issue in 2025.1.0.
Fixes #1.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.