store the documents in s3 through cartifact #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eacrew/polypress into CU-868gmw643_Allow-Polypress-to-scale
saikumar9
reviewed
Dec 30, 2025
app/operations/documents/copy.rb
Outdated
| # Handles copying documents to Cartafact and constructing required headers | ||
| module Documents | ||
| class Copy | ||
| include Dry::Monads[:result] |
Member
There was a problem hiding this comment.
@geetha-1z Please review the other operation implementations and ensure that Dry Monads :do is used here as well, so yield can be used. This will help maintain consistent operation class implementations across Ideacrew, including Polypress.
saikumar9
reviewed
Dec 30, 2025
| @@ -0,0 +1,55 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Also, make sure to add unit tests before sending this for peer code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/868gmw6re