Open
Conversation
tahiralmas
reviewed
Feb 8, 2021
Member
tahiralmas
left a comment
tahiralmas
left a comment
There was a problem hiding this comment.
Please check my comments, and update the code accordingly
| /** | ||
| * Export Csv | ||
| * | ||
| * @url GET /export/users |
Member
There was a problem hiding this comment.
Follow project standard for url, note the ending s in users and /csv suffix for file format
@url GET /users/csv
| * @url GET /export/users | ||
| * | ||
| */ | ||
| public function export_list($query = array()) |
Member
There was a problem hiding this comment.
Move this code into UserApi.php and drop this file
also rename it to export_csv, as we are going to delete the following function with the same name
|
|
||
| $oUser=array(); | ||
|
|
||
| $oUser = new User($user_id); |
Member
There was a problem hiding this comment.
No need to export single user record to csv, if needed it can be filtered via above created export_csv function, see the search filter.
| /** | ||
| * Export User by User id | ||
| * | ||
| * @url GET /export/user/$user_id |
Member
There was a problem hiding this comment.
drop this function in favor of sample_csv
| /** | ||
| * Provide User Sample | ||
| * | ||
| * @url GET /export/users/sample |
Member
There was a problem hiding this comment.
- use project standard format for url
@url GET users/sample/csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.