feat: support rolldown as an experimental engine#688
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds experimental support for Rolldown as a new bundling engine alongside the existing Rollup and RSLib engines. The implementation includes engine detection, Rolldown-specific configuration options, and comprehensive test coverage.
- Add Rolldown as a new engine type with full configuration support
- Implement Rolldown bundling functionality with shared utilities from Rollup
- Add comprehensive integration tests for React components using Rolldown
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/pkg/src/types.ts | Add 'rolldown' to EngineType union |
| packages/pkg/src/tasks/bundle.ts | Implement Rolldown build handling and fix bundle.write binding |
| packages/pkg/src/engine/rolldown/options.ts | New Rolldown options configuration using shared Rollup utilities |
| packages/pkg/src/engine/rollup/options.ts | Export shared utilities for use by Rolldown |
| packages/pkg/src/helpers/taskConfig.ts | Add bundle task assertion helper |
| packages/pkg/package.json | Add rolldown dependency |
| tests/helpers/run.ts | Fix test cleanup order and use serialize-javascript for config |
| tests/integration/react/* | Add React integration tests with Rolldown support |
| tests/integration/default/index.test.ts | Add Rolldown bundle test case |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c78e47c to
358f4cb
Compare
358f4cb to
085e7de
Compare
More templates
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.