Skip to content

Merge pull request #1 from icattlecoder/dev #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icattlecoder wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Merge pull request #1 from icattlecoder/dev #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fff2a
Merge pull request #1 from icattlecoder/dev
icattlecoder Jun 27, 2014
ae28f9f
feat: 避免 -d 出现循环调用 (#7)
fantacymaker Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion godaemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func init() {
args := os.Args[1:]
i := 0
for ; i < len(args); i++ {
if args[i] == "-d=true" {
if args[i] == "-d" || args[i] == "-d=true" {
Copy link

@greptile-apps greptile-apps bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The space-separated format -d true is also valid for Go boolean flags. When this format is used, the loop finds -d and converts it to -d=false, but leaves true as a dangling argument. Consider handling this case:

Suggested change
if args[i] == "-d" || args[i] == "-d=true" {
if args[i] == "-d" || args[i] == "-d=true" {
if args[i] == "-d" && i+1 < len(args) && args[i+1] == "true" {
args = append(args[:i+1], args[i+2:]...)
}
args[i] = "-d=false"
break
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: godaemon.go
Line: 20:20

Comment:
**style:** The space-separated format `-d true` is also valid for Go boolean flags. When this format is used, the loop finds `-d` and converts it to `-d=false`, but leaves `true` as a dangling argument. Consider handling this case:

```suggestion
			if args[i] == "-d" || args[i] == "-d=true" {
				if args[i] == "-d" && i+1 < len(args) && args[i+1] == "true" {
					args = append(args[:i+1], args[i+2:]...)
				}
				args[i] = "-d=false"
				break
			}
```

How can I resolve this? If you propose a fix, please make it concise.

args[i] = "-d=false"
break
}
Expand Down