Clusterrole updated #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
We don't need as many permissions. Can you test without endpoints, services, events, and most important: secrets? |
Works too :)
Author
|
Removed endpoints, services, events and secrets. Works! |
Owner
|
Looks good. Do you have a 1.5 cluster handy to test, whether the cluster role also works there? I could only test some time next week. Also, I prefer if you could rebase the changes to one logical change, I.e. group the Readme changes and the cluster role change. Thank you! |
Author
|
At the moment, I don't have a 1.5 cluster at hand. Sorry. And I will look into rebasing soon. |
Owner
|
Don't worry, I will test later that week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the clusterrole.yaml from openshift-acme.
It fixes #26.