-
Notifications
You must be signed in to change notification settings - Fork 43
[patch] Add gitops initial user creation automation FVT test #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2025
whitfiea
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an automated test to the fvt-preparer task to drive and verify the new automation for creating initial users in SaaS deployments.
See https://pages.github.ibm.com/maximoappsuite/saas/walkthrough/#automated-creation-of-initial-users for details.
The test runs twice: once in the core phase and once again in the apps phase (to drive the logic that grants application roles and assigns Manage Security Groups to the initial users):
The results of the tests are registered with the FVT dashboard under ibm-mas-gitops/initial-users-automation ${LAUNCHER_ID}-${MAS_INSTANCE_ID}
This SaaS-specific test is performed in the pipeline itself (rather than in the fvt-suites) since the ArgoCD sync window established for the duration of the fvt-suites run would prevent ArgoCD from resyncing the initial-users Job after we delete it (which is the only sensible way to retrigger it).
The script is designed to not block the whole FVT run if something goes wrong.
Related PRs
ibm-mas/python-devops#66
ibm-mas/gitops#278
https://github.ibm.com/maximoappsuite/saas-tekton/pull/127
Testing
Verified running in situ against noble4: dev-gitops-mas-fvt-preparer run:
Also run manually from laptop to test failure cases: