IBX-10978: Added tel/mailto options to urlType #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
reithor
force-pushed
the
ibx-10978-add-tel-mailto-to-urltype
branch
from
a7b72e4 to
12c8017
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
PR disables Symfony's
FixUrlProtocolListenerand introduces a customFixUrlProtocolListener.Symfony's
FixUrlProtocolListenerconsiders URLs liketel:123456(without//) as having no protocol.Those URLs will wrongly be prefixed with
http://.(Technically URLs like
tel:123456are valid).Own implementation fixes this behavior.
For now only
telandmailtoare added as allowed scheme - further improvement could make this part more flexible via config,Reference for URL syntax:
https://en.wikipedia.org/wiki/URL#Syntax
For QA:
Documentation: