make EcdsaKeyPair tagged union public together with its init function#22
Merged
ianic merged 2 commits intoianic:mainfrom Jan 7, 2026
Merged
make EcdsaKeyPair tagged union public together with its init function#22ianic merged 2 commits intoianic:mainfrom
ianic merged 2 commits intoianic:mainfrom
Conversation
Owner
|
Sorry for letting this linger for so long. Can you change that into method of the CertKeyPair. So we have |
Contributor
Author
|
Oh my bad, the code in the comment is just a example, I just require the init function to EcdsaKeyPair be marked as public. I'm looking at the diff in the changed files and it looks terrible, my bad. |
Contributor
Author
|
Something like this? No errors with |
Owner
|
Thanks! I needed to fix paths (remove root) in order to pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where I wanted the certs to be embedded into the binary and was unable to do so due to EcdsaKeyPair tagged union init function being private, with the tagged union being public I can now do something like this:
Thought this change might be useful, feel free to ignore if it's not something you want or if its a bad idea