1.4 #2
Merged
1.4 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: enricodias <enricodias@gmail.com>
Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Fix grammar in contributing docs
…ting big layouts succeed in redirecting (this is not happening anywhere AFAIK *yet*)
Use PHPUnit's `assertMatchesRegularExpression()`
Drop "go to a" from bigLayout as it might accidentally make tests testing big layouts succeed in redirecting
Round x y to prevent implicit int conversion
I have added a way to read css metrics that are the same as standard ones except that they consider retina displays. Now the lib works in headful mode on retina displays.
…#312) * Add support for --no-proxy-server and --proxy-bypass-list Chrome args Co-authored-by: Karl Pierce <kpierce@ratespecial.com>
* Replace microtime with hrtime The system clock shouldn't interfere with the calculation of timeouts. * Cleanup * Update OperationTimedOut.php Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
* Add failing test * Fix `Mouse::find()` after cursor has moved After scrolling to the element, its boundaries change and we have to read the viewport offsets in order to compute final coordinates. * Update Mouse.php Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
* Fix missing destroyed * Update Session.php Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
* Update Node.php Fix bug with zero node id * Add tests for querySelector returns null
Closes #361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in origin changes.