St fix to support ruby19#1
Open
sthirugnanasambandam wants to merge 2 commits intoiamwilhelm:masterfrom
Open
Conversation
- replace colon with arrows as colon with String Object as hash keys not supported in 1.9
- virtual attributes are not initialized properly - #reset method has necessary code to initialize the virtual attributes. - just update initialize block by calling #reset
Owner
|
@sthirugnanasambandam How come you're using ruby 1.9? I see that support for ruby 1.9.3 has already ended. I'm not sure I'd want to support ruby versions that even the official ruby lang won't be supporting. Though I'm not using too many 2.0+ features right now, I feel that I should at least keep it at least in rubies that are being supported. So that's why I'm curious why you're still using 1.9.x? |
Author
|
@iamwilhelm We are in process of moving to ruby 2.x. Ours is a mammoth project. So we will be migrating very soon. Having said that the ruby 1.9.3 support has just ended couple of months back and I am pretty sure there are tons of teams out there still using 1.9.3 or in process of migrating to 2.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to support ruby 1.9
- replace colon with arrows as colon with String Object as hash keys
not supported in 1.9
Update initialize block