Skip to content

Conversation

@iamvirul
Copy link
Owner

Description

This PR adds a [package] section to the root Cargo.toml to enable running integration tests in tests/boot_tests.rs. Previously, the tests were not runnable because integration tests require an associated package.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update
  • Build system / CI changes
  • Other (please describe):

Related Issues

Fixes the inability to run tests/boot_tests.rs integration tests.

Changes Made

Code Changes

Build System:

  • Added [package] section to root Cargo.toml with name ferrous-kernel-tests
  • Uses workspace-level metadata (version, edition, authors, license, repository)

Testing

Tests can now be run with:

cargo test --test boot_tests

Output:

running 3 tests
test test_boot_sequence_documented ... ok
test test_harness_works ... ok
test test_memory_region_types_documented ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

ADR Requirements

  • This change requires an ADR
  • This change does not require an ADR
  • ADR status: N/A

Safety Considerations

  • This PR contains unsafe Rust code
  • This PR is security-critical
  • This PR has no safety/security implications

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested in QEMU (if applicable)
  • All existing tests pass

Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Code is commented, particularly for complex logic
  • Documentation updated (if applicable)
  • No new warnings generated
  • Tests added/updated and passing
  • All unsafe code has safety comments
  • Changes are backward compatible
  • Commit messages follow the project's guidelines

Additional Context

The tests/boot_tests.rs file contains documentation tests describing memory region types and boot sequence stages.

The tests/boot_tests.rs file was not runnable because the workspace
root Cargo.toml lacked a [package] section. Integration tests require
an associated package to run.
@iamvirul iamvirul merged commit 8f68c66 into main Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants