Android Oreo Issues Has Been Resolved. by zeeshanrasool91 · Pull Request #30 · iamjazzar/rosetta

zeeshanrasool91 · 2018-06-21T12:52:23Z

Process Phoenix Has Been Added for restarting Application work better then refresh method....

iamjazzar · 2018-06-23T10:24:52Z

Hello @zeeshanrasool91, and thanks for the contribution. Is this ready for review now?

zeeshanrasool91 · 2018-06-27T09:51:53Z

yes it is ready for review

iamjazzar · 2018-06-29T12:11:01Z

app/src/main/java/com/ahmedjazzar/rosetta/app/BaseActivity.java

+
+    @Override
+    protected void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);


No need for this method if it doesn't contain changes.

@zeeshanrasool91 Any updates ion this?

iamjazzar · 2018-06-29T12:12:01Z

app/src/main/java/com/ahmedjazzar/rosetta/app/MainApplication.java

 package com.ahmedjazzar.rosetta.app;

 import android.app.Application;
+import android.content.Context;


Why all these unused imports?

@zeeshanrasool91 Any updates on these?

iamjazzar · 2018-06-29T12:12:22Z

app/src/main/res/values-v21/styles.xml

        <item name="windowNoTitle">true</item>
        <item name="android:windowDrawsSystemBarBackgrounds">true</item>
-        <item name="android:statusBarColor">@android:color/transparent</item>
+        <item name="android:statusBarColor">@color/colorPrimaryDark</item>


Is this change necessary?

it was actually showing me transparent view on my Lollipop device.

iamjazzar · 2018-06-29T12:13:01Z

build.gradle

 allprojects {
    repositories {
        jcenter()
+        google()


Are we using this repository?

it is required by Latest Compat Libraries

iamjazzar · 2018-06-29T12:13:48Z

rosetta/src/main/java/com/ahmedjazzar/rosetta/LanguagesListDialogFragment.java


                mLogger.info("App locale changed successfully.");
-                LocalesUtils.refreshApplication(getActivity());
+                //LocalesUtils.refreshApplication(getActivity());


Just remove it

when i was using your refresh method the problem was that it was recreating application and current activity both.
i just wanted to recreate whole application. so it can recreate all resources in my application

Cool with me, but just no need to comment, removing the line is enough.

iamjazzar · 2018-06-29T12:13:57Z

rosetta/src/main/java/com/ahmedjazzar/rosetta/LocalesUtils.java


        if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale))   {
-            LocalesUtils.refreshApplication(activity);
+            //LocalesUtils.refreshApplication(activity);


Just remove it.

when i was using your refresh method the problem was that it was recreating application and current activity both.
i just wanted to recreate whole application. so it can recreate all resources in my application

Cool with me, but just no need to comment, removing the line is enough.

iamjazzar · 2018-06-29T12:14:50Z

rosetta/src/main/java/com/ahmedjazzar/rosetta/ProcessPhoenix.java

@@ -0,0 +1,131 @@
+/*


Can't we just include it instead of copying and pasting it?

i did it but was Creating problems that's why added it as a file, i tried to solve it once i will check then will commit this code.

i did it so buddy. i added it as Dependency but for that i have to Add

in my Manifest in Main Default launcher Activity, other wise was causing crash.

zeeshanrasool91 · 2018-06-29T13:58:54Z

Process Pheonix was Creating Issue when we included just because of Some intent filters

…

On Fri, Jun 29, 2018 at 5:14 PM Ahmed Jazzar ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In app/src/main/java/com/ahmedjazzar/rosetta/app/MainApplication.java <#30 (comment)>: > @@ -1,7 +1,11 @@ package com.ahmedjazzar.rosetta.app; import android.app.Application; +import android.content.Context; Why all these unused imports? ------------------------------ In app/src/main/res/values-v21/styles.xml <#30 (comment)>: > @@ -4,6 +4,6 @@ <item name="windowActionBar">false</item> <item name="windowNoTitle">true</item> <item name="android:windowDrawsSystemBarBackgrounds">true</item> - <item ***@***.***:color/transparent</item> + <item ***@***.***/colorPrimaryDark</item> Is this change necessary? ------------------------------ In build.gradle <#30 (comment)>: > @@ -15,6 +16,7 @@ buildscript { allprojects { repositories { jcenter() + google() Are we using this repository? ------------------------------ In rosetta/src/main/java/com/ahmedjazzar/rosetta/LanguagesListDialogFragment.java <#30 (comment)>: > @@ -153,7 +153,8 @@ protected void onPositiveClick() { getActivity(), mSelectedLanguage)) { mLogger.info("App locale changed successfully."); - LocalesUtils.refreshApplication(getActivity()); + //LocalesUtils.refreshApplication(getActivity()); Just remove it ------------------------------ In rosetta/src/main/java/com/ahmedjazzar/rosetta/LocalesUtils.java <#30 (comment)>: > @@ -265,7 +265,8 @@ static boolean setLocale(Locale newLocale, Activity activity) { } if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale)) { - LocalesUtils.refreshApplication(activity); + //LocalesUtils.refreshApplication(activity); Just remove it. ------------------------------ In rosetta/src/main/java/com/ahmedjazzar/rosetta/ProcessPhoenix.java <#30 (comment)>: > @@ -0,0 +1,131 @@ +/* Can't we just include it instead of copying and pasting it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHFTed1n9CtmLgq7GP1mxwYfXVSSbVY9ks5uBhpDgaJpZM4UyAYl> .

-- Regards: Zeeshan Rasool

zeeshanrasool91 · 2018-06-29T14:35:37Z

@AhmedAljazzar now you can Check and tell me

iamjazzar · 2018-06-30T08:11:39Z

app/src/main/java/com/ahmedjazzar/rosetta/app/MainApplication.java

 package com.ahmedjazzar.rosetta.app;

 import android.app.Application;
+import android.content.Context;


@zeeshanrasool91 Any updates on these?

iamjazzar · 2018-06-30T08:12:06Z

app/src/main/java/com/ahmedjazzar/rosetta/app/BaseActivity.java

+
+    @Override
+    protected void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);


@zeeshanrasool91 Any updates ion this?

iamjazzar · 2018-06-30T08:13:17Z

rosetta/build.gradle


-apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
-apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle'
+//apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'


No need to comment, just remove the line.

iamjazzar · 2018-06-30T08:13:31Z

rosetta/build.gradle

-apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
-apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle'
+//apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
+//apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle'


No need to comment as well, just remove the line.

iamjazzar · 2018-06-30T08:14:19Z

rosetta/src/main/java/com/ahmedjazzar/rosetta/LanguagesListDialogFragment.java


                mLogger.info("App locale changed successfully.");
-                LocalesUtils.refreshApplication(getActivity());
+                //LocalesUtils.refreshApplication(getActivity());


Cool with me, but just no need to comment, removing the line is enough.

iamjazzar · 2018-06-30T08:14:52Z

rosetta/src/main/java/com/ahmedjazzar/rosetta/LocalesUtils.java


        if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale))   {
-            LocalesUtils.refreshApplication(activity);
+            //LocalesUtils.refreshApplication(activity);


Cool with me, but just no need to comment, removing the line is enough.

zeeshanrasool91 added 2 commits June 21, 2018 17:51

Android Oreo Issues Has Been Resolved.

1c645f3

Process Phoenix Has Been Added for restarting Application work better then refresh method....

CodeCleaned up

7857e40

iamjazzar reviewed Jun 29, 2018

View reviewed changes

iamjazzar requested changes Jun 29, 2018

View reviewed changes

Removed Process Phoenix and Added as Dependency

b59f924

iamjazzar requested changes Jun 30, 2018

View reviewed changes

iamjazzar force-pushed the master branch from dd8114c to f209545 Compare July 7, 2018 12:44

zeeshan-rasool-index added 2 commits March 30, 2020 15:50

Updated to AndroidX Component

e1f647b

Planning to update to Kotlin

aa011ce

Conversation

zeeshanrasool91 commented Jun 21, 2018

Uh oh!

iamjazzar commented Jun 23, 2018

Uh oh!

zeeshanrasool91 commented Jun 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zeeshanrasool91 commented Jun 29, 2018 via email

Uh oh!

zeeshanrasool91 commented Jun 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants