Remove RASA components #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoB0
requested changes
Sep 30, 2025
Collaborator
NoB0
left a comment
NoB0
left a comment
There was a problem hiding this comment.
The following files can also be removed:
test_diet_classifier_rasa.pytest_annotation_converter_dialoguekit_to_rasa.py
Also the __init__.py files in the following packages should be updated to remove Rasa related component:
nlupackage should remove import ofIntentClassifierRasautilspackages should removeAnnotationConverterRasasample_agentsshould removeRasaParrotAgent
| @@ -1,4 +1,4 @@ | |||
| """Convert annotations to be compatible with the rasa models.""" | |||
Collaborator
There was a problem hiding this comment.
I believe that this file can be removed, along with the associated test file.
Contributor
Author
There was a problem hiding this comment.
I was considering this, yes. Done.
NoB0
approved these changes
Sep 30, 2025
Collaborator
NoB0
left a comment
NoB0
left a comment
There was a problem hiding this comment.
LGTM. Please add requests to requirements.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267