Enhance Create3 with Advanced Navigation and Docking Sensor Logic#53
Open
Fouad-Smaoui wants to merge 1 commit intoiRobotEducation:pre_0.7.0from
Open
Enhance Create3 with Advanced Navigation and Docking Sensor Logic#53Fouad-Smaoui wants to merge 1 commit intoiRobotEducation:pre_0.7.0from
Fouad-Smaoui wants to merge 1 commit intoiRobotEducation:pre_0.7.0from
Conversation
…and obstacle avoidance
shamlian
reviewed
Jun 9, 2025
Collaborator
shamlian
left a comment
There was a problem hiding this comment.
Disclaimer: I am no longer an employee of iRobot Corporation but it seems I'm implicitly the steward of this repository.
This is impressive work. Would you mind adding an example (you could just crib them from the text of this PR, if you want) to examples/create3_robots ? Once you do that I'd be happy to merge to pre_0.7.0.
| # Update cached values | ||
| self.docking_sensor.contacts = packet.payload[4] != 0 | ||
| self.docking_sensor.sensors = (packet.payload[5], | ||
| packet.payload[6], |
Collaborator
There was a problem hiding this comment.
Could you restore the indentation on this tuple, please?
| packet = await completer.wait(self.DEFAULT_TIMEOUT) | ||
| if packet: | ||
| unpacked = unpack('>IBBBBHHHH', packet.payload) | ||
| return {'timestamp': unpacked[0], 'contacts': unpacked[1], 'IR sensor 0': unpacked[2], |
Collaborator
There was a problem hiding this comment.
Thanks, this is much more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement advanced navigation and docking sensor improvements
Overview
This PR enhances the Create3 robot's capabilities by implementing sophisticated navigation features and addressing pending TODO items. The changes focus on improving autonomous movement, obstacle avoidance, and docking sensor functionality.
Major Changes
1. TODO Items Implementation
Docking Sensor Enum
DockSensorEnumfor structured sensor state managementEvent Trigger System
when_docking_sensor_triggerfor granular event handlingDocking Values Optimization
get_docking_values2. Advanced Navigation Features
Waypoint Navigation
Waypointdataclass for structured navigation pointsnavigate_to_waypointfor precise navigationfollow_waypointsfor sequential navigationObstacle Avoidance
navigate_with_obstacle_avoidancefor safe navigationNavigation State Management
NavigationStatefor comprehensive state trackingTechnical Details
Configuration Parameters
Usage Examples
Docking Sensor Usage
Navigation Usage
Safety Features