Skip to content

Conversation

@AliHCS
Copy link

@AliHCS AliHCS commented Jan 13, 2024

#44 - Gustavo Ali Gómez Trejo

Se corrigio el combine para la validacion de repetir el password

Copy link
Member

@3zcurdia 3zcurdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM[8]

5598D3222B2403CF00A6AFD3 /* CircularImage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5598D3212B2403CE00A6AFD3 /* CircularImage.swift */; };
5598D3242B24049B00A6AFD3 /* ProfileCardView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5598D3232B24049B00A6AFD3 /* ProfileCardView.swift */; };
5598D3262B2404FC00A6AFD3 /* ProfileCardVM.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5598D3252B2404FC00A6AFD3 /* ProfileCardVM.swift */; };
E63894902B2D0EF200B7D57C /* CatsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = E638948F2B2D0EF200B7D57C /* CatsView.swift */; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file not needed on PR

@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not needed on PR

var body: some Scene {
WindowGroup {
ContentView()
SignUpView()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required for testing view

Comment on lines +10 to +22
struct CatsView: View {
var body: some View {
List {
ForEach((1..<20)){ _ in

}
}
}
}

#Preview {
CatsView()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be skiped on PR

Comment on lines +1 to +8
//
// CatsView.swift
// SwiftUIBasics
//
// Created by Gustavo Ali Gómez Trejo on 15/12/23.
//

import Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

$password
.receive(on: RunLoop.main)
.map { password in
let pattern = "[!\"#$%&'()*+,-./:;<=>?@\\[\\\\\\]^_`{|}~]+"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let pattern = "[!\"#$%&'()*+,-./:;<=>?@\\[\\\\\\]^_`{|}~]+"
let pattern = "[\\W]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants