Skip to content

Conversation

@jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Sep 10, 2025

BEGINRELEASENOTES

  • Fix a few warnings related to unused variables
  • Remove a comment that doesn't make sense anymore without the removed variables

ENDRELEASENOTES

Warnings like:

/Marlin/source/src/SimpleFastMCProcessor.cc:198:48: warning: unused parameter 'evt' [-Wunused-parameter]
  198 |   void SimpleFastMCProcessor::check( LCEvent * evt ) {
      |                                                ^
1 warning generated.
[94/128] Building CXX object Marlin/source/CMakeFiles/Marlin.dir/src/XMLParser.cc.o
/Marlin/source/src/XMLParser.cc:198:18: warning: variable 'procCount' set but not used [-Wunused-but-set-variable]
  198 |         unsigned procCount(0) ;
      |                  ^
/Marlin/source/src/XMLParser.cc:199:18: warning: variable 'typedProcCount' set but not used [-Wunused-but-set-variable]
  199 |         unsigned typedProcCount(0) ;
      |                  ^

@tmadlener
Copy link
Contributor

The changes that would fix the warning in the SimpleFastMCProcessor are now gone it seems?

@jmcarcell
Copy link
Contributor Author

Brought back, I'm not sure it's always necessary though since it depends if MARLIN_AIDA is defined or not.

@tmadlener
Copy link
Contributor

Unless there are more, I would merge.

@jmcarcell
Copy link
Contributor Author

I don't see any more, apparently the ones in #53 do not happen anymore. I probably have a Clang 2 or 3 versions newer.

@tmadlener tmadlener merged commit 622690f into iLCSoft:master Sep 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants