Conversation
Changes:
- Add S3 URL support for topology files and startup configs
- Add IsS3URL() helper to identify S3 URLs
- Add ParseS3URL() to parse bucket and key from S3 URLs
- Update CopyFileContents() to handle S3 downloads
- Update ProcessTopoPath() to support S3 topology files
- Update processStartupConfig() to support S3 startup configs
- Add unit tests for S3 URL parsing and validation
- Add documentation for S3 usage
Implementation uses MinIO Go client (github.com/minio/minio-go/v7) which:
- Provides AWS credential chain support (env vars, ~/.aws/credentials, IAM roles)
- Also supports .env files for AWS credentials
- Keeps binary size impact minimal (~+1MB vs ~+7MB with AWS SDK)
- Works with S3 and S3-compatible storage services
Example usage:
# Deploy with S3 topology
containerlab deploy -t s3://my-bucket/topologies/lab.yml
# Reference S3 startup configs in topology
nodes:
router1:
startup-config: s3://my-bucket/configs/router1.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing workflows