Migrate Laravel View #304
Open
Migrate Laravel View #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR migrates Laravel View functionality to Hypervel, including comprehensive test coverage for Blade compilation, view components, and the view engine system. The migration includes test fixtures, unit tests for various Blade directives and features, and core source files for the view service provider, view name normalization, and engine implementations.
Key Changes:
- Added comprehensive test suite covering Blade compilation features (150+ test files)
- Implemented ViewServiceProvider for dependency injection and service registration
- Added ViewName class for view name normalization
- Created ViewFinderInterface defining the view finder contract
- Implemented ViewException for view-specific error handling
- Added ShareErrorsFromSession middleware for error handling
- Implemented FileEngine for raw file rendering
Reviewed changes
Copilot reviewed 150 out of 151 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/View/fixtures/* | Test fixture files for view rendering tests |
| tests/View/ViewTest.php | Unit tests for View class functionality |
| tests/View/ViewPhpEngineTest.php | Tests for PHP engine |
| tests/View/ViewFileViewFinderTest.php | Tests for file view finder |
| tests/View/ViewFactoryTest.php | Comprehensive tests for view factory |
| tests/View/ViewEngineResolverTest.php | Tests for engine resolver |
| tests/View/ViewComponentTest.php | Tests for view components |
| tests/View/ViewComponentAttributeBagTest.php | Tests for component attributes |
| tests/View/ViewCompilerEngineTest.php | Tests for compiler engine |
| tests/View/ViewBladeCompilerTest.php | Tests for Blade compiler |
| tests/View/ComponentTest.php | Component integration tests |
| tests/View/Blade/* | Extensive Blade directive compilation tests |
| src/view/src/ViewServiceProvider.php | Service provider for view system |
| src/view/src/ViewName.php | View name normalization utility |
| src/view/src/ViewFinderInterface.php | Interface for view finding |
| src/view/src/ViewException.php | Custom exception for views |
| src/view/src/Middleware/ShareErrorsFromSession.php | Middleware for error sharing |
| src/view/src/Engines/FileEngine.php | File-based rendering engine |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.