Skip to content
This repository was archived by the owner on Apr 19, 2023. It is now read-only.

🟢 Release v0.1.0 #4

Open
alexmodrono wants to merge 4 commits into
base: root
Choose a base branch
from
Open

🟢 Release v0.1.0 #4

alexmodrono wants to merge 4 commits into from

Conversation

@alexmodrono
Copy link
Member

@alexmodrono alexmodrono commented Dec 26, 2021

Changes Overview
This PR makes the following changes:

  • BREAKING CHANGE: .navigationBarElement() no longer works (the function is still there though it will probably be deleted before the final version).
  • Introduces a new way for adding navigation bar elements that replaces the old way.
  • Allows for more customization of elements thanks to NavigationBarProxy.
  • Adds a way to check for the library's version number.

Does this PR fix, close, or implement any issues?

  • This PR does not close, fix, or implement any issue
  • This is a release check.

Pending for review
@hyperspacedev/swift-ui

@iAlex11
chore(navigation_bar)!: changed the way navigation bar elements were …
7f3062a 
…created.

BREAKING CHANGE: now navigation bar elements are passed as arguments to the style, so `.navigationBarElement()` is no longer used.
@iAlex11
fix(navigation_bar): change order of trailing and leading elements.
f36a2b3
@iAlex11
Merge pull request #3 from hyperspacedev/Features/gh-2
dcf0b07 
🚧 New way for adding navigation bar elements
@iAlex11
chore(version): Added version number to StylableScrollView
37a4126
@alexmodrono alexmodrono added the release This is a new release label Dec 26, 2021
@alexmodrono alexmodrono added this to the v0.1.0 milestone Dec 26, 2021
@alexmodrono alexmodrono requested a review from a team December 26, 2021 13:36
@alexmodrono alexmodrono self-assigned this Dec 26, 2021
alicerunsonfedora
alicerunsonfedora approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@alicerunsonfedora alicerunsonfedora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alicerunsonfedora alicerunsonfedora alicerunsonfedora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexmodrono alexmodrono

Labels

release This is a new release

Projects

None yet

Milestone

v0.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexmodrono @alicerunsonfedora @iAlex11