This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: skip runtime installation during build#971
Merged
mattjohnsonpint merged 3 commits intomainfrom Sep 3, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --no-runtime flag to the modus sdk install command to skip runtime installation during CI/CD builds, and updates CLI dependencies to their latest versions.
- Introduces
--no-runtimeflag to SDK install command for conditional runtime installation - Updates build command to use the new flag when installing SDKs during builds
- Updates multiple CLI dependencies to their latest versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/src/commands/sdk/install/index.ts | Adds --no-runtime flag and conditional runtime installation logic |
| cli/src/commands/build/index.ts | Updates SDK installation call to include --no-runtime flag |
| cli/package.json | Updates CLI dependencies to latest versions |
| CHANGELOG.md | Documents the new feature in changelog |
Files not reviewed (1)
- cli/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--no-runtimeflag tomodus sdk install, and uses it when installing SDKs duringmodus build. This is primarily to allowmodus buildto be used in CI/CD without an unused Modus Runtime becoming installed into the build runner.Also updates CLI dependencies to latest.