This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Closed
Conversation
Comment on lines
+12
to
+16
| path: Args.directory({ | ||
| description: "Path to app directory", | ||
| default: ".", | ||
| exists: true, | ||
| }), |
Contributor
There was a problem hiding this comment.
Please validate that this will work if the app path is to the source code OR to the build folder. The logic should be:
- If a
buildfolder exists under the given path, use the wasm, json, and env files from there. - If not, then expect them to exist directly at the given path.
This will allow for both running locally and for copying the build folder elsewhere and running directly.
You may need to adjust stuff in the DevCommand, or copy it here.
Contributor
Author
There was a problem hiding this comment.
That's easy enough. The main limitation here is finding the SDK version.
I suppose the order of operations for determining the SDK version might be:
- Look for a
package-lock.jsonin the current directory. - If not found, check the parent directory (
../) for apackage-lock.json. - If neither exists, fall back to using the latest version.
Alternatively, you could extract the SDK version directly from the .wasm file metadata
Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says