This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: repair runtime prerelease matching bug and update dependencies#894
Merged
mattjohnsonpint merged 4 commits intomainfrom Jun 12, 2025
Merged
fix: repair runtime prerelease matching bug and update dependencies#894mattjohnsonpint merged 4 commits intomainfrom
mattjohnsonpint merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
A PR to repair a runtime prerelease matching bug and update dependency versions to ensure smoother CLI operations.
- Ensure OS architecture is consistently handled as a string.
- Update the runtime prerelease determination logic to correctly account for both flag and version prerelease conditions.
- Bump dependency versions and update the CHANGELOG accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/src/util/installer.ts | Converted os.arch() to string for consistency with OS platform handling. |
| cli/src/commands/sdk/install/index.ts | Updated runtime prerelease logic to merge flags and version prerelease checks. |
| cli/package.json | Upgraded dependency versions to new releases. |
| CHANGELOG.md | Documented the bug fix and dependency updates in the changelog. |
Comments suppressed due to low confidence (1)
cli/src/commands/sdk/install/index.ts:75
- [nitpick] Consider adding a brief comment to clarify why the runtimePrerelease flag is determined by combining flags.prerelease and the prerelease status of args.version. This can improve future maintainability.
const runtimePrerelease = flags.prerelease || (!!args.version && vi.isPrerelease(args.version));
kevinmingtarja
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a CLI issue where
modus buildormodus devon a pre-release version update would give this error:Also updated dependencies and adjusted code to match.