This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: fully install go sdk in dev mode#837
Merged
mattjohnsonpint merged 4 commits intomainfrom May 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the installation of the Go SDK in dev mode by ensuring the modus-go-build tool is correctly installed. The changes include an enhanced check in sdkVersionIsInstalled for the Go build tool, refactoring the dev command to reuse the SDK install command, and updating the changelog.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/src/util/versioninfo.ts | Adds an extra check for the Go build tool and cleans up incomplete installs |
| cli/src/commands/dev/index.ts | Refactors SDK installation logic to reuse the shared SDKInstallCommand |
| CHANGELOG.md | Documents the fix in the changelog |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ryanfoxtyler
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are three paths that a Modus SDK can be installed via the CLI:
modus sdk installmodus buildmodus devThe first two were correct, but the latter was not installing the
modus-go-buildtool.Fixed by:
modus dev, just likemodus buildwas doing alreadymodus-go-buildtool is missingChecklist
All PRs should check the following boxes:
Conventional Commits syntax, leading with
fix:,feat:,chore:,ci:, etc.the contributing guide.
If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)
CHANGELOG.mdfile.