Decouple Cred Generation from file system depnedencies and side effects#458
Open
jmbarzee wants to merge 2 commits intohyperledger:mainfrom
Open
Decouple Cred Generation from file system depnedencies and side effects#458jmbarzee wants to merge 2 commits intohyperledger:mainfrom
jmbarzee wants to merge 2 commits intohyperledger:mainfrom
Conversation
move credential loading into client split remaining file operations expose key generation functions to be used without side effects Signed-off-by: Jacob Barzee <jmbarzee@gmail.com>
jmbarzee
force-pushed
the
jmbarzee/cred-gen-lib
branch
from
a3177a3 to
847b79d
Compare
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Your changes look good to me, and the code structure is nice and clean.
My primary concern is that this module is not really intended to be consumed as a library. It is the implementation of the Fabric CA (binary) application and accompanying CLI commands. This change makes it more usable as a library, and I am not sure this is something we should be supporting. What do you think @denyeart?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Just enables the client packages to be used as libraries without the file system side effects. This is critical for workflow systems that leverage ephemeral workflows to manipulate or rotate credentials.
Additional details
Changes are fully backwards compatible, and are covered entirely by existing tests.
Related issues
N/A
Release Note
lib/client now supports certificate generation without file system side effects.
Checklist (Pending Items):
Signed-off-byadded to commits (required for DCO check to pass)