Skip to content

feat: Add nu/build.nu for assets building#206

Merged
hustcer merged 2 commits intomainfrom
develop
Feb 6, 2026
Merged

feat: Add nu/build.nu for assets building#206
hustcer merged 2 commits intomainfrom
develop

Conversation

@hustcer
Copy link
Owner

@hustcer hustcer commented Feb 6, 2026

feat: Add nu/build.nu for assets building

Summary by CodeRabbit

  • Chores
    • Streamlined build process by introducing an automated build script, replacing manual multi-step commands.
    • Integrated Nu setup into CI/CD workflows to enhance build environment initialization.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR integrates Nu into the build and CI/CD processes. GitHub Actions workflows now set up Nu, and a new Nu script automates the build process previously executed by a complex npm script. The package.json build command is simplified to invoke the Nu script.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build.yaml, .github/workflows/use-nightly.yaml
Added setup-nu action step after Node setup in both build jobs to initialize Nu in the CI environment.
Build Automation
nu/build.nu, package.json
Introduced new Nu script that automates build, minification, file renaming (exec-child.js → exec-child.cjs), and reference updates. Simplified package.json build script to delegate to the Nu script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through build commands with glee,
Nu scripts now dance where shell once would be,
Cleaner, swifter, a buildtime delight,
Workflows align, everything's right!
🎉

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Code Analysis

  • Key observations: The changes primarily involve build system improvements rather than frontend application code. The main changes are:
    1. Added Nu shell script (build.nu) to replace complex shell commands in package.json
    2. Updated GitHub workflows to include Nu shell setup
    3. Simplified the build script in package.json to use the Nu script
    4. The build process handles renaming exec-child.js to exec-child.cjs and updating references

Security Review

  • Vulnerability findings: No frontend security vulnerabilities detected in the provided build system changes. The changes are focused on build tooling and don't affect runtime security aspects like XSS prevention, CSRF protection, or data handling.

Optimization Suggestions

  • Performance improvements:
    1. Consider adding caching for the Nu setup in GitHub workflows to reduce build times
    2. The build script could benefit from parallel execution if multiple build steps are added in the future
    3. Consider implementing incremental builds for development workflows

Overall Quality: 4

Rationale: The changes demonstrate good engineering practices by:

  • Simplifying complex shell commands into a maintainable Nu script
  • Improving build process clarity and maintainability
  • Maintaining consistent build behavior across different environments
  • Following good version control practices with clear, focused commits

The rating is 4 (not 5) because while the changes are good, they don't directly impact the frontend application's runtime performance, security, or user experience. The improvements are primarily in the development tooling area.

@hustcer hustcer merged commit 928c8f8 into main Feb 6, 2026
117 of 118 checks passed
@github-actions github-actions bot added this to the v3.23 milestone Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant