Save cache when SDK built successfully, regardless of the later workflow's failure. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please! This is rather annoying. Currently when the build fails, this isn't cached, meaning it has to build it again on the next run; eating up more of my CI minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
actions/cachestores the built Vulkan SDK cache only after the workflow completes. Even if the Vulkan SDK is successfully built, it will not be cached if a subsequent workflow fails.This PR enhances the caching mechanism by using
actions/cache/restoreandactions/cache/saveinstead ofactions/cache. This fine-grained mechanism ensures that the Vulkan SDK cache is saved immediately upon a successful build, regardless of the success or failure of later workflows, thereby reducing unnecessary build time.