Fix/consistent path normalization #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhance safety in path extension handling - Fix path validation tests to work with actual error messages - Prioritize extension validation over other path format issues - Ensure consistent error handling across prompt and agent clients
This change: - Replaces hardcoded directories with pytest's tmp_path fixture - Eliminates filesystem pollution between tests - Enables safe test parallelization - Improves path validation and error messages - Removes redundant cleanup code - Makes tests follow pytest best practices
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
peadaroh
reviewed
May 16, 2025
…hatMessageParams type
- Add detailed explanation of function's purpose and usage contexts\n- Document rationale for stripping leading/trailing slashes\n- Add comprehensive examples for different path formats\n- Reference SyncClient.pull usage for context
…ix/consistent-path-normalization
Consolidate the three similar test loops (extension paths, slash paths, and combined paths) into a single parametrized test. This reduces code duplication while making test cases more maintainable and test output more descriptive. - Replace repetitive test loops with @pytest.mark.parametrize - Use descriptive test IDs for better test output - Group test cases by type with clear comments - Make parameter names more explicit (path_generator, test_case_description)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the diffs are from rewriting/adding/removing tests.
The core logic that changed was the handling of paths in the
.call()and.log()operations when using local files.