Skip to content

HA-7926 / Loop Results per Page #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hheight wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HA-7926 / Loop Results per Page #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions cypress/e2e/table.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,45 @@ context("table element", function() {
});
});

describe("when element have data-os-results-per-page attribute", () => {
beforeEach(() => {
cy.visit("/").then(() => {
cy.request("/").then((response) => {
const body = `
<body>
<os-table data-os-results-per-page="100" data-os-element="loop" data-os-view="view_uuid"></os-table>
</body>
`;

const modifiedHtml = response.body.replace(
/<body>[\s\S]*<\/body>/,
body,
);

cy.intercept("/", modifiedHtml);
});
});
});

it("calls response views items endpoint with rows_per_page param", function() {
cy.intercept(
"GET",
"**/api/v1/response_views/view_uuid/items*",
{
data: [],
},
).as("responseViewsItems");

cy.visit("/");

cy.wait("@responseViewsItems").then((interceptor) => {
expect(interceptor.request.url).to.match(
/response_views\/view_uuid\/items\?rows_per_page\=100/,
);
});
});
});

describe("when response view have items", () => {
it("renders table with data", function() {
cy.intercept(
Expand Down
7 changes: 6 additions & 1 deletion src/components/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export class OSTable extends HTMLElement {

if (haveLoopAttribute) {
const responseViewUuid = this.getAttribute("data-os-view");
const resultsPerPage = this.getAttribute("data-os-results-per-page");
let params = '';
if (resultsPerPage) {
params = `?rows_per_page=${resultsPerPage}`;
}
if (responseViewUuid) {
const emptyElement = document.createElement("div");
emptyElement.innerText = "No data found";
Expand All @@ -21,7 +26,7 @@ export class OSTable extends HTMLElement {
this.dispatchLoadingEvent(true);

fetch(
`${requestHost}/api/v1/response_views/${responseViewUuid}/items`,
`${requestHost}/api/v1/response_views/${responseViewUuid}/items${params}`,
{
credentials: "include",
headers: {
Expand Down