Skip to content

Conversation

@akesson
Copy link
Member

@akesson akesson commented Jan 10, 2026

Summary

  • Exposes daemon PID to the on_startup callback for logging/registration
  • Bumps version to 0.10.0 (breaking change)

Test plan

  • cargo build passes
  • cargo test passes (56 tests)

🤖 Generated with Claude Code

akesson and others added 2 commits January 10, 2026 12:44
Exposes the daemon's process ID to the on_startup callback, allowing
users to log or register the PID when the daemon starts.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 10, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Breaking API change: CommandHandler::on_startup() signature now accepts a second parameter pid: u32. Package version bumped to 0.10.0 and changelog updated; trait definition and the startup call site updated to pass the daemon PID.

Changes

Cohort / File(s) Summary
Version and Changelog
CHANGELOG.md, Cargo.toml
Bumped package version to 0.10.0; added CHANGELOG entry under "Changed (BREAKING)" noting CommandHandler::on_startup() now receives pid: u32.
Trait API and Call Site
src/lib.rs, src/server.rs
CommandHandler::on_startup signature changed from fn on_startup(&self, _reason: StartupReason) to fn on_startup(&self, _reason: StartupReason, _pid: u32); server startup now calls handler with pid.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a pid parameter to the on_startup callback, which is reflected in all modified files (trait signature update, version bump, and call site update).
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the purpose (exposing daemon PID for logging/registration), the version bump impact (breaking change), and verification through testing.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dceadb and bac9f53.

📒 Files selected for processing (1)
  • CHANGELOG.md

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @CHANGELOG.md:
- Line 8: The changelog entry header for version 0.10.0 has the wrong year
("2025-01-10"); update the date in the CHANGELOG.md header line "## [0.10.0] -
2025-01-10" to the correct year "2026-01-10" so the release date matches the PR
and current date.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbd905a and 7dceadb.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • Cargo.toml
  • src/lib.rs
  • src/server.rs
🔇 Additional comments (3)
Cargo.toml (1)

3-3: LGTM!

The version bump to 0.10.0 correctly follows semantic versioning for a breaking API change.

src/server.rs (1)

231-232: LGTM!

The startup notification correctly passes the daemon PID to the handler, enabling implementors to log or register the process ID as intended.

src/lib.rs (1)

424-429: LGTM!

The trait signature update correctly adds the PID parameter, enabling handlers to log or register the daemon process ID. The use of _pid prefix is idiomatic for optional parameters, and the documentation clearly explains the new capability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@akesson akesson merged commit dadb3ff into main Jan 10, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants