Add customFetch to env for user override#1538
Merged
xenova merged 1 commit intohuggingface:mainfrom Feb 21, 2026
Merged
Conversation
xenova
reviewed
Feb 20, 2026
Collaborator
xenova
left a comment
xenova
left a comment
There was a problem hiding this comment.
Thanks for the PR! Definitely something i think we should add.
In terms of naming, why not just simplify it to env.fetch instead? :) (I may have suggested env.customFetch in the past, but if we reference it in code like this, maybe the former is simpler.
Contributor
Author
|
fine with me! |
xenova
approved these changes
Feb 20, 2026
Collaborator
xenova
left a comment
xenova
left a comment
There was a problem hiding this comment.
LGTM ✅ Will wait for @nico-martin's review too, in case he has any thoughts :)
Contributor
Author
|
I have one change related to the type. |
sroussey
force-pushed
the
replace-fetch
branch
from
a5922df to
861ebcc
Compare
nico-martin
approved these changes
Feb 21, 2026
Collaborator
nico-martin
left a comment
nico-martin
left a comment
There was a problem hiding this comment.
I thinkt thats a great feature!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1182 and #1479