Fix: respect --max_seq_len for sliding window models with custom kv cache + sdpa#219
Open
rhn19 wants to merge 1 commit intohuggingface:mainfrom
Open
Fix: respect --max_seq_len for sliding window models with custom kv cache + sdpa#219rhn19 wants to merge 1 commit intohuggingface:mainfrom
rhn19 wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218
Changes
_prepare_export_inputs: usemax_dim = max_seq_len - 1instead ofmin(max_seq_len, sliding_window) - 1when ring cache is activeexport: bypassTorchExportableModuleWithHybridCache.__init__to preventStaticSlidingWindowLayerbaking a<= sliding_windowguard into the exported graphTested on
google/gemma-3-1b-itwith--max_seq_len 1024 --use_custom_kv_cache --use_custom_sdpa,prompt > 512 tokens