Fix crash after failed audio download in process_conversation_inputs#217
Open
kirklandsign wants to merge 1 commit intohuggingface:mainfrom
Open
Fix crash after failed audio download in process_conversation_inputs#217kirklandsign wants to merge 1 commit intohuggingface:mainfrom
kirklandsign wants to merge 1 commit intohuggingface:mainfrom
Conversation
The except block printed an error but let execution fall through to torchaudio.load(buf) where buf was undefined, causing an UnboundLocalError. Re-raise as RuntimeError with the URL and cause. Also add timeout=30 to requests.get() to prevent indefinite hangs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The except block printed an error but let execution fall through to torchaudio.load(buf) where buf was undefined, causing an UnboundLocalError. Re-raise as RuntimeError with the URL and cause. Also add timeout=30 to requests.get() to prevent indefinite hangs.