Fix broken error handling for unregistered task/recipe lookup#216
Open
kirklandsign wants to merge 1 commit intohuggingface:mainfrom
Open
Fix broken error handling for unregistered task/recipe lookup#216kirklandsign wants to merge 1 commit intohuggingface:mainfrom
kirklandsign wants to merge 1 commit intohuggingface:mainfrom
Conversation
`dict.get()` returns `None` on missing keys instead of raising `KeyError`, making the `except KeyError` block dead code. An invalid task or recipe would fall through as `None` and later crash with an unhelpful `TypeError: 'NoneType' object is not callable`. Replace with an explicit membership check that surfaces the available task/recipe names in the error message. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dict.get()returnsNoneon missing keys instead of raisingKeyError, making theexcept KeyErrorblock dead code. An invalid task or recipe would fall through asNoneand later crash with an unhelpfulTypeError: 'NoneType' object is not callable.Replace with an explicit membership check that surfaces the available task/recipe names in the error message.