Open
Conversation
Introduce CustomRingKVCacheWithSink and ETCustomAttentionSinkCache that preserve the first sink_size tokens while using a ring buffer for the remaining window. Add get_custom_sdpa_for_attention_sink to build per-layer attention masks with sink token preservation. Wire the attention_sink parameter through replace_with_et_custom_kv_cache. Co-authored-by: Claude <noreply@anthropic.com>
Register a dedicated custom_sdpa_attention_sink attention implementation when the attention_sink option is provided, with priority over the existing ring KV cache SDPA path. Pass attention_sink through to the cache setup at export time.
kirklandsign
commented
Feb 23, 2026
| try: | ||
| from executorch.examples.models.llama.source_transformation.attention_sink import ( | ||
| CachePositionsManagerWithSink, | ||
| _create_causal_mask_for_attention_sink, |
Author
There was a problem hiding this comment.
Will need to wait for et side change to merge first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.