Skip to content

Conversation

@onel
Copy link

@onel onel commented Jan 14, 2026

I wanted to update the guides with more example of usage for LocalFuncRepository and LockedFuncRepository

Copy link
Collaborator

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution ! just left few nits

### Loading from a local repository for testing

The `LocalLayerRepository` class is provided to load a repository from
The `LocalLayerRepository` class is provided to load a layer repository from
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can have repositories that contain layers, and functions at the same time, so there is not such thing as layer repository and function repository

Comment on lines +389 to +393

The parameters are:
- `repo_path`: Path to the local kernel repository directory
- `package_name`: The Python package name of the kernel
- `func_name`: The name of the function within the kernel repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we don't need to add this, it's already very explicit within the example, wdyt ?

Comment on lines +49 to +50
Locked functions can also be used with `LockedFuncRepository`. This is useful for stateless
layers or functions that were converted with `use_kernel_func_from_hub`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is accurate since all layers are stateless, maybe we can just say

Suggested change
Locked functions can also be used with `LockedFuncRepository`. This is useful for stateless
layers or functions that were converted with `use_kernel_func_from_hub`:
Locking is also supported for functions, just like for layers, through the use of `LockedFuncRepository`:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants