Add support for kernel versions #209
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for kernel versions branches as implemented by `kernel-builder`: * `kernels upload` will upload the branch corresponding to the kernel's version. * `get_kernel`, `LayerRepository`, etc. accept version branches through the `version` argument. * Kernel locking (e.g. `kernels lock`) support reading version branches from `pyproject.yaml` and correctly locking them. All the kernel functions and layers already supported a `version` argument for version specifiers (based on tags). These are now overloaded -- if `version` is a `str`, it is parsed as a version specifier. If it is an `int`, it is used as a version branch. This overloading is used to gradually move to version branches, deprecating version specifiers. For now, using version specifiers will emit a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for kernel versions branches as implemented by
kernel-builder:kernels uploadwill upload the branch corresponding to the kernel's version.get_kernel,LayerRepository, etc. accept version branches through theversionargument.kernels lock) support reading version branches frompyproject.yamland correctly locking them.All the kernel functions and layers already supported a
versionargument for version specifiers (based on tags). These are now overloaded -- ifversionis astr, it is parsed as a version specifier. If it is anint, it is used as a version branch.This overloading is used to gradually move to version branches, deprecating version specifiers. For now, using version specifiers will emit a warning.