Fix Perplexity Score For Tokenizers without bos_token_id#682
Merged
lhoestq merged 1 commit intohuggingface:mainfrom Jun 20, 2025
Merged
Conversation
|
Fwiw, I'm running into the same problem and haven't yet worked out how to get a perplexity score when the input is a single token. |
Member
|
good catch ! thanks for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Tokenizer's, like Qwen2.5's, don't include a
bos_token_id.Which means using the model with the perplexity metric fails.
Results in this error, caused by the tokeniser not containing a
bos_token_id:There is also a similar PR for the transformers library itself to handle this situation back in February: fix: condition bos_token_id and space as token #36211
This PR adds a
not Nonecheck to the add bos_token_id block.