feat(toFile): the situation where compatible paths cannot exist#84
Open
feat(toFile): the situation where compatible paths cannot exist#84
Conversation
If the path cannot exist, create the path If there is a path, follow the original logic normally
huan
requested changes
Mar 6, 2024
Owner
huan
left a comment
huan
left a comment
There was a problem hiding this comment.
Please modify code as requested.
And,
- please add a param comment (jsdoc) to the
overwriteparameter to explain the new feature. - please add an unit test to test this new feature.
| // Check if file exists | ||
| let exist = false; | ||
| try { | ||
| FS.accessSync(fullFilePath); |
Owner
There was a problem hiding this comment.
use async instead of sync, with await, please
| // Create directory if it doesn't exist | ||
| const directory = PATH.dirname(fullFilePath); | ||
| if (!FS.existsSync(directory)) { | ||
| FS.mkdirSync(directory, { recursive: true }); |
Owner
There was a problem hiding this comment.
only do the mkdir if the overwrite is true
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/file-box.ts:903
- [nitpick] Consider renaming the variable 'exist' to 'exists' to better reflect that it represents a boolean value, which would improve clarity.
let exist = false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the path cannot exist, create the path
If there is a path, follow the original logic normally