Open
Conversation
mikewest
approved these changes
Feb 3, 2026
Member
mikewest
left a comment
mikewest
left a comment
There was a problem hiding this comment.
This looks like a reasonable approach to me, thanks!
Nit: Can you link the thread in the commit message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there was some discussion on the review email thread about expanding on the Accept-Encoding angle, I think that will risk overcomplicating the topic and risk confusing readers. Especially since the Intro tries to make the point that we don't need/want to do something like send
Accept-Encoding: identity. Instead I tried to do this implicitly by expanding the para on content coding omission a bit.