feat: [WIP] Reconstruct neighbour mesh locally 2#314
Open
sbstndb wants to merge 19 commits intohpc-maths:mainfrom
Open
feat: [WIP] Reconstruct neighbour mesh locally 2#314sbstndb wants to merge 19 commits intohpc-maths:mainfrom
sbstndb wants to merge 19 commits intohpc-maths:mainfrom
Conversation
- Before, we only are able to send the whole mesh structure - For performance reasons, we should only send a part of it - So here are the correspondinf functiosn that send only cells[id] of m_subdomain - TODO : delete update_mesh function - TODO : factorize the two functions for cells[id] and subdomain. It is maybe more complex
- Previously, we send the whole mesh structure - But it is not needed. - Here are the modified sends reduced in size that improve the performance
- Add definition - Add template mesh_id_t properly
- Add non-const to be able to write with operator[] - TODO : is it preferable to use a setter to preserve the [] as const ?
- Before: we send/recv the neighbourhood cells_and_ghosts - But we can avoid MPI comms by reconstructing it locally - At this point, the advection-2d case works fine
- I suggest decompose the mesh_id steps in subfunctions - This is now easier to reconstruct the subdomain mesh locally !!
- For each subdomain, we reconstruct cells_and_ghosts_ and reference and prijection. - TODO : there is a segfault for the periodic one.
- For now, lets check without periodic
Contributor
Author
|
At this point, this PR works at least for advection-2D.
|
- Now only for the rank mesh - TODO : resolve the issue when launched for the neighbour mesh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on #307 so please review the PR#307 before
Related issue
How has this been tested?
advection-2d
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct